nifi icon indicating copy to clipboard operation
nifi copied to clipboard

NIFI-10651 Upgrade Iceberg transitive dependencies

Open exceptionfactory opened this issue 3 years ago • 2 comments

Summary

NIFI-10651 Upgrades multiple transitive dependencies in Apache Iceberg components to align with current versions also defined for Apache Hive components. These transitive dependencies have various associated vulnerabilities and should be upgraded to align with versions in other Apache NiFi modules.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • [X] Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • [X] Pull Request based on current revision of the main branch
  • [X] Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • [X] Build completed using mvn clean install -P contrib-check
    • [X] JDK 8
    • [ ] JDK 11
    • [ ] JDK 17

Licensing

  • [ ] New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • [ ] New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • [ ] Documentation formatting appears as expected in rendered files

exceptionfactory avatar Oct 14 '22 15:10 exceptionfactory

Hi @exceptionfactory, thanks for looking through the dependencies and correcting the vulnerable versions. My only question is that is it necessary to include dependencies like calcite or avatica since they are excluded and not present in the built bundles.

mark-bathori avatar Oct 18 '22 08:10 mark-bathori

Thanks for the feedback @mark-bathori, good catch on the Calcite dependencies! I brought those other along with other Hive-related dependencies, but you are correct that they are not included. I will remove the Calcite and Avatica references.

exceptionfactory avatar Oct 18 '22 13:10 exceptionfactory

+1 LGTM, thanks for the review @mark-bathori and thanks for the improvements @exceptionfactory ! Merging to main

mattyb149 avatar Oct 18 '22 17:10 mattyb149