Kevin Rushforth

Results 600 comments of Kevin Rushforth

I'd like to see this get resolved for JavaFX 20. I note there is a similar issue with `TableView`, which is tracked by [JDK-8187145](https://bugs.openjdk.org/browse/JDK-8187145). As I mentioned in that JBS...

I took a look at the bug description for [JDK-8230098](https://bugs.openjdk.org/browse/JDK-8230098), and it should be closed as a duplicate of [JDK-8279640](https://bugs.openjdk.org/browse/JDK-8279640) rather than adding both as solved by this PR (adding...

> So no CSR is needed, I think. Probably you are right if all we end up doing is clarifying existing behavior. For example, if we add a sentence to...

Quite possibly. Can you check it as part of fixing [JDK-8187145](https://bugs.openjdk.org/browse/JDK-8187145) and expand that issue to cover TreeTableView if needed?

I recommend trying this with the following gradle flags, to match the settings for production builds: ``` -PCONF=Release -PPROMOTED_BUILD_NUMBER=NNN -PHUDSON_BUILD_NUMBER=MMM -PHUDSON_JOB_NAME=jfx -PCOMPILE_WEBKIT=true -PCOMPILE_MEDIA=true -PBUILD_LIBAV_STUBS=true ``` where `NNN` is the promoted...

The WebKit build is complicated (to say the least). All of the WebKit components, including the additional third-party dependencies in `/Source/ThirdParty`, are built using cmake. I think any changes would...

I should add that if changes are needed to the `Makefile.msvc` files to accept extra link flags to be passed in, then it would be fine to modify them.

Ideally the latter, if feasible, so that the logic to handle `SOURCE_DATE_EPOCH` is more localized.