Kevin Rushforth
Kevin Rushforth
/reviewers 2
> Don't worry about the CSR for now, someone will create it when the review is near completion. However, since this is an enhancement, you should discuss it first in...
Moving this to `Draft` to make it clear that it isn't yet ready for review.
Can you provide an automated test for this? Since this is touching common code, what testing have you done to ensure no regressions on other platforms when not using Monocle?...
That would certainly be a safer (more targeted) fix. I'd like to hear from @jperedadnr and @johanvos on this.
> May be it has sense to add a drag event handler (which disarms the corresponding button) to ButtonBehavior only if javafx.platform is set to monocle to localize the fix...
> We do more experimental things in Monocle, but I think we simply need to get this issue right. Yes, this is the better approach. If we proceed with this...
Can you say why the `doEnd` call is not needed for the Java platform? Have you verified that there is no adverse effect to skipping it? /reviewers 2