Kevin Rushforth

Results 600 comments of Kevin Rushforth

I took a closer look, and the current PR has at least one problem. The call to `synchronizeSceneNode` must only be done with the `renderLock` held. If you are using...

> To solidify my understanding - the "RenderScenegraph" is only allowed to be changed when the render lock is held. This scene graph is represented by all these NG classes,...

This will require careful review and testing to make sure that we don't introduce any cases where the binding disappears too soon. The main thing we need to be careful...

I see from your comment in PR #635 that you propose to withdraw that PR in favor of this one. Given that, why don't you change that one to "Draft"...

> I've decided that if this PR goes forward we should abandon #672. The changes in #672 would be bypassed for KeyEvents generated by physical keystrokes. For a while I...

The bug is posted here: [JDK-8264591](https://bugs.openjdk.java.net/browse/JDK-8264591): HBox/VBox child widths pixel-snap to wrong value