Ilya Maykov
Ilya Maykov
I'm probably being too pedantic here, but we should probably use a proper KDF rather than hmac. Some options would be: HKDF, PBKDF, or Argon2.
Support for multiple wallets was added in #580, but we still need to update the docs with instructions for how to use this. Auto-initialize + finalize has not been worked...
LGTM, but the commit needs to be signed. @prasanth08 you will need to set up GPG signing and sign the commit before we can merge it.
Hi @prasanth08, the commit still says "Unverified" if you click the Commits tab. I think you should `git commit --amend --gpg-sign=...` and then do a forced push to your fork....
Sure, that's fine too. I'll close this PR and wait for a new one!
Found another, possibly related bug: struct fields of aliased types are omitted by impl_debug. For example: ``` union IPv4Address { unsigned char bytes[4]; uint32_t words[1]; }; struct IPv4AddressAndPort { union...
I think you need to add some test cases