Refactor - Remove unused import

Open prasanth08 opened this issue 3 years ago • 1 comments

Remove unused imports

Sep 10 '22 19:09 prasanth08

All committers have signed the CLA.

Sep 10 '22 19:09 CLAassistant

LGTM, but the commit needs to be signed.

@prasanth08 you will need to set up GPG signing and sign the commit before we can merge it.

Apr 10 '23 18:04 ivmaykov

I've added the gpg keys.

Apr 11 '23 04:04 prasanth08

Hi @prasanth08, the commit still says "Unverified" if you click the Commits tab. I think you should git commit --amend --gpg-sign=... and then do a forced push to your fork. I also recommend that you rebase your branch onto the latest master so you don't have an unnecessary merge commit.

Apr 11 '23 04:04 ivmaykov

I think its best i cut a new branch and make a new pull request.

Apr 12 '23 03:04 prasanth08

Sure, that's fine too. I'll close this PR and wait for a new one!

Apr 12 '23 03:04 ivmaykov

Raised a new one https://github.com/square/subzero/pull/583

Apr 12 '23 16:04 prasanth08