Harsh Deshpande

Results 89 comments of Harsh Deshpande

Sorry for the delay. I rebased my branch on `master` and it builds fine now. I will work on the the remaining things soon and update the PR. BTW while...

> do we have action_bridge for dedicated binary? I was thinking adding action_bridge feature for dynamic, static bridges would be better for user. As @dirk-thomas commented, I will add the...

@dirk-thomas The Dockerfile is not generating the interfaces anymore. The interface mapping files were empty. This is my Dockerfile: ``` FROM ubuntu:20.04 SHELL ["/bin/bash", "-c"] RUN apt update RUN apt-get...

@v-lopez thanks for the offer. I can ping you next week to start working on this again. Sorry for keeping this hanging for so long.

Not sure if the `signoff` went wrong since quite some old commits have been stacked here. Tested the bridge and works well with the `master` branch. Running the tests shows...

@RaAndOn no, the `mapping_rules.yaml` is not ignored. Please follow https://github.com/ros2/ros1_bridge/issues/285 and https://github.com/ros2/ros1_bridge/issues/285#issuecomment-732798700. That being said, there is a logical error, will push new commit with a fix.

Rebased from `master`. Current status: - `action_bridge` bridges action interfaces bi-directionally. - `dynamic_bridge` is able to `print-pairs` for actions ``` $ ros2 run ros1_bridge dynamic_bridge --print-pairs Supported ROS 2 ROS...

I have updated the `dynamic_bridge` and tested with Fibonacci. Is anyone willing to test it? I will update the README in the meantime. EDIT: I am not sure if [this](https://github.com/ipa-hsd/ros1_bridge/blob/e9af1aad2178647b551b49976c123928013b0d0c/include/ros1_bridge/action_factory.hpp#L81-L88)...

I am guessing this is a known issue? https://github.com/ros2/ros1_bridge/pull/256/checks?check_run_id=2762818577#step:3:87

@ruffsl I should have added this in the README. I added a `mapping_rules.yaml` in [action_tutorials_interfaces](https://github.com/ros2/demos/tree/master/action_tutorials/action_tutorials_interfaces) package. ``` # This file defines mappings between ROS 1 and ROS 2 interfaces. #...