Sarah Gillespie
Sarah Gillespie
> this works perfectly for user/password login but it doesn't work for SSO, is this expected? Good eye! I was wondering the same and need to follow up with the...
@zwass, not currently, but I did last sprint so I can take a closer look if that makes sense for folks
@marcosd4h, would you please let me know your results when running the following live query: ``` SELECT os.name, r.data FROM os_version os, ( SELECT data FROM registry WHERE path =...
Thanks! It seems like we'll need product to take a closer look at this and see how they'd like to handle this case. @noahtalerman, @lukeheath it seems like the windows...
@marcosd4h, I've opened a [PR](https://github.com/fleetdm/fleet/pull/8030) that I believe should resolve this issue. Would you mind trying it out in your environment? Thanks!
As discussed in estimation, linking to this [ticket](https://github.com/fleetdm/fleet/issues/15884) that also relates to the disk encryption endpoint
I'm afraid younger me was responsible for [this](https://github.com/fleetdm/fleet/pull/833). We should definitely rework our approach. I'll take a closer look and follow up with more comments.
Notes and todos from [7127](https://github.com/fleetdm/fleet/pull/7217#issue-1339389305) will help to improve this situation. See also my comments to [7460](https://github.com/fleetdm/fleet/pull/7460).
Additional integration test coverage will follow in a separate PR
> Looks good, just a few minor things and I think the changes file might be missing? The goal is to add integration tests post-freeze, correct? Yes, thanks! And I...