Add logging to capture user email upon successful login
Issue #7888
Checklist for submitter
If some of the following don't apply, delete the relevant line.
- [x] Changes file added for user-visible changes (in
changes/and/ororbit/changes/). - ~~Documented any API changes (docs/Using-Fleet/REST-API.md or docs/Contributing/API-for-contributors.md)~~
- ~~Documented any permissions changes~~
- ~~Input data is properly validated,
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)~~ - ~~Added support on fleet's osquery simulator
cmd/osquery-perffor new osquery data ingestion features.~~ - [x] Added/updated tests
- [x] Manual QA for all new/changed functionality
Test summary
Run details
| Project | Fleet |
| Status | Passed |
| Commit | 3f8bd6d5d9 ℹ️ |
| Started | Sep 27, 2022 6:52 PM |
| Ended | Sep 27, 2022 7:07 PM |
| Duration | 15:12 💡 |
| OS | Linux Ubuntu - 20.04 |
| Browser | Electron 94 |
View run in Cypress Dashboard ➡️
Flakiness
|
|
cypress/integration/premium/teamflow.spec.ts |
1 |
|
|---|---|---|---|
| 1 | Teams flow (seeded) > Manage schedules page > adds a query to team schedule |
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
Codecov Report
Base: 60.71% // Head: 60.71% // Increases project coverage by +0.00% :tada:
Coverage data is based on head (
1d73302) compared to base (f7b341c). Patch coverage: 100.00% of modified lines in pull request are covered.
Additional details and impacted files
@@ Coverage Diff @@
## main #7927 +/- ##
=======================================
Coverage 60.71% 60.71%
=======================================
Files 437 437
Lines 41778 41778
=======================================
+ Hits 25364 25367 +3
+ Misses 14015 14013 -2
+ Partials 2399 2398 -1
| Impacted Files | Coverage Δ | |
|---|---|---|
| server/contexts/logging/logging.go | 50.00% <ø> (ø) |
|
| server/service/sessions.go | 74.10% <100.00%> (+0.66%) |
:arrow_up: |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
this works perfectly for user/password login but it doesn't work for SSO, is this expected?
Good eye! I was wondering the same and need to follow up with the team on their logging expectations around SSO. I'm planning to open an issue to track SSO logging separately.