Geoffrey Foster

Results 10 issues of Geoffrey Foster

http://www.openradar.me/33107135 In FunctionalTableData, when the contextual actions are being created, we can determine if the cell is this height and instead return a pre-rendered (and likely cached) image that includes...

Bug
Pinned

This would allow us to persist our current state easily and write a snapshot style test assert that a section matches the recorded encoded section.

Pinned

Now that we can just use an URL in the Playgrounds app (or I just TIL today about it), we can make this a playground book as well Check out...

Pinned

Remove our custom difference computation and replace with a more maintainable one. Current options on the table are [DifferenceKit](https://github.com/ra1028/DifferenceKit) and/or Swift 5.1's built in [Collection Difference](https://github.com/apple/swift/blob/master/stdlib/public/core/CollectionDifference.swift). The Swift 5.1 one...

Pinned

CellConfigType, TableSection, and ItemPath all use String's for their key's, we should instead use AnyHashable which makes things a bit nicer and easier to use (no need to convert Hashable...

Pinned

We are basing the editing style on the presence of rowActions/leading/trailing config. This isn't right but is needed for the moment for backwards compatibility. https://github.com/Shopify/FunctionalTableData/commit/795046694d85f5370e798c77813aefce7fccd954 We should instead provide a...

Pinned

The JSON "EnterMessage" is received but the room never displays the "user has joined this chat" message and they do not appear in the rooms list of users

Campfire service seems to periodically send a kick message to the signed in user (not sure why). Plugin then tries to reconnect but doesn't do the full join and gets...

Any message that comes through as a tweet type doesn't show up in the conversation. Need to finish adding support for tweet message type.