FunctionalTableData icon indicating copy to clipboard operation
FunctionalTableData copied to clipboard

UIContextualAction won't render both image and text if cell is <= 90pts

Open g-Off opened this issue 6 years ago • 2 comments

http://www.openradar.me/33107135

In FunctionalTableData, when the contextual actions are being created, we can determine if the cell is this height and instead return a pre-rendered (and likely cached) image that includes both the text and the image. This might be a configurable property to allow it to be opted in or out.

This could have some side effects in scenarios where the cell changes size while the action is visible (device rotation, tableview gets wider).

g-Off avatar Apr 11 '19 15:04 g-Off

This could have some side effects in scenarios where the cell changes size while the action is visible (device rotation, tableview gets wider).

What I've done in the past is simple set editing for the cell to false in those scenarios, which returns the cell back to the normal state without the contextual actions visible. I would argue that this solution is satisfactory in most cases; likelihood of the cell changing height without a rotation is small for most use cases.

Likewise, check an app like Messages.app. Swipe to reveal actions and then rotate your device to landscape or vice versa 💩

runmad avatar Apr 23 '19 03:04 runmad

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 3 days if no further activity occurs.

ghost avatar May 14 '19 04:05 ghost