Santiago Figueroa Manrique
Santiago Figueroa Manrique
Minor: Now I don't see it in the chat notes, but didn't we agree to remove the [FEATURE] thing before the title for the issues as well? Or am I...
A good thing to keep in mind is that we first need to add the handling for angles to the core (c++) validation module, as it is currently missing. That...
Also, we can potentially add a `readme.md`to each test folder to explicitly explain what is what on each case.
I agree with the proposal. Here are some additional comments: - Before using pointers, we should first resort to things like `std::span` or what we have now available in `std::ranges`...
> Use a reference member causes the class to be not-assignable, which is required for many STL containers. This could be a problem. For example, a `vector` of `MathSolver` requires...
I like the cleanup. Now I wonder, should we move `all_components.hpp` to the `component` folder? Also seems intuitive to me to rename `component.hpp` to `all_components_fwd.hpp`, or somehow homogenize the two....
Hello @WinApiMan, I want to let you know that we are actively working on this issue. We have found some leads, but nothing conclusive yet. We will communicate with you...
Hi @emabre, since @mgovers is out of office, I will give you a hand. > * In `validation.utils` only `errors_to_string()` is intended for end users, according to the comment in...
Hi @emabre, After discussion with the team, these are the conclusions: - Let's make `validation.validation` a private module (`validation._validation`) , and instead expose `assert_valid_data_structure` in the `__init__.py`. Hence, `assert_valid_data_structure` should...
> @figueroa1395 should the name of this PR be changed to only re-route validation tests? PR edited accordingly.