power-grid-model icon indicating copy to clipboard operation
power-grid-model copied to clipboard

[FEATURE] Validation test cases: Validation case test runner in the package

Open nitbharambe opened this issue 7 months ago • 2 comments

Describe the feature request

From the discussion in #1017 , We wish to have the validation case runner available in the PGM python package itself. Users can then run their own cases and submit to PGM.

We can also separate out a dataset_equal function. This utility can then verify if the datasets match, with appropriate handling for angles, along with rtol/atol. It can then be used by users in their own tests.

This would then include separating test_single_validation and compare_result functions.

nitbharambe avatar Jun 23 '25 07:06 nitbharambe

A good thing to keep in mind is that we first need to add the handling for angles to the core (c++) validation module, as it is currently missing. That should probably be step one. Car. https://github.com/PowerGridModel/power-grid-model/blob/894488396a998b4a10b30beba1b30e683e9154ec/tests/cpp_validation_tests/test_validation.cpp#L235

figueroa1395 avatar Jun 23 '25 09:06 figueroa1395

A good thing to keep in mind is that we first need to add the handling for angles to the core (c++) validation module, as it is currently missing. That should probably be step one. Car.

power-grid-model/tests/cpp_validation_tests/test_validation.cpp

Line 235 in 8944883

// TODO need a way for common angle: u angle skipped for now

@figueroa1395 I think we are talking about Python validation script here. The C++ validation test is out of scope.

TonyXiang8787 avatar Jun 23 '25 11:06 TonyXiang8787