power-grid-model icon indicating copy to clipboard operation
power-grid-model copied to clipboard
verified publisher icon PowerGridModel

Cleanup main model: Make components to be forward declared

Open nitbharambe opened this issue 4 months ago • 2 comments

Idea is to make components forward declared to reduce coupling.

This draft PR is created for gathering thoughts and requirements as of now.

Changes proposed in this PR include:

  • Forward declared all components
  • Removed unecessary exception and logging includes.

nitbharambe avatar Sep 29 '25 15:09 nitbharambe

I like the cleanup. Now I wonder, should we move all_components.hpp to the component folder? Also seems intuitive to me to rename component.hpp to all_components_fwd.hpp, or somehow homogenize the two.

In addition, can we also include component_list in this "revolution"? Perhaps it now belongs in component.hpp and we try to keep all component related stuff in one location only.

figueroa1395 avatar Oct 01 '25 14:10 figueroa1395

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Oct 20 '25 09:10 sonarqubecloud[bot]