Dmitriy Fingerman

Results 13 comments of Dmitriy Fingerman

> Is the jira reference correct; I don't understand wha'ts the connection with [HIVE-26496](https://issues.apache.org/jira/browse/HIVE-26496). @zabetak The connection to HIVE-26496 is that you raised the problem around assignment of bucketId in...

Hey @ayushtkn thanks for reviewing! Can you please merge it? I have no write access yet..

> In my opinion this approach looks more expensive, maybe we should reach out to iceberg community with the. proposal to extend current API with atomic IOW semantic? I agree...

Please fill in the PR template to give some information about these changes.

Hi @cxzl25, I did a test on my local env: backported this patch into Orc branch 1.9, built Hive with it then run the Hive query test that had been...

There are several Sonar issues in the modified classes. Other than that LGTM +1.

Hi @abstractdog, Thanks for the review! Here are screenshots of: 1. login page 2. An attempt to login with empty creds 3. Before submitting good creds. 4. After login.

Thanks a lot for review and +1, @abstractdog! I handled the comment regarding the formatting. I also added one more comment about ignoring exception in ThriftHttpServlet: https://github.com/apache/hive/pull/5399#discussion_r1747272788

Why are these methods don't do anything? ``` @Override public void createCatalog(Catalog catalog) throws AlreadyExistsException, InvalidObjectException, MetaException, TException { } @Override public void alterCatalog(String catalogName, Catalog newCatalog) throws NoSuchObjectException, InvalidObjectException,...