apache
Respect Decimal isRepeating flag
What changes were proposed in this pull request?
Decimal type, when isRepeating itself is false, do not try to change it.
Why are the changes needed?
https://github.com/apache/hive/pull/5218#discussion_r1647367003
How was this patch tested?
Add UT
Was this patch authored or co-authored using generative AI tooling?
No
Hi @cxzl25, I did a test on my local env: backported this patch into Orc branch 1.9, built Hive with it then run the Hive query test that had been failing before and it passed. Can you please create a new Orc release from branch 1.9 so that we could use it in Hive? This is because we can't use Orc 2.0 or later because it requires Java 17+ and Hive still support Java 8.
If this is not a bug, please set the milestone of this PR to ORC 2.1.0. Otherwise, please set the milestone to 1.9.5 and change the JIRA issue type from Improvement to Bug.
This is just a draft PR, it should not be considered a bug.
Which version is this PR targeting
If the introduction of ORC-1266 causes Hive calculation results to be inaccurate, in order to ensure that Hive can use the 1.9.x version, I hope to merge it into the 1.9 branch.
If that is your intention, please switch it to Bug instead of Improvement because we don't backport Improvement in core module.
Anyway, that's too bad because we missed 1.9.4 release train.