apache
HIVE-28581: Support Partition Prunning stats optimization for Iceberg tables
What changes were proposed in this pull request?
Add support for Iceberg partition prune stats optimization
Why are the changes needed?
Performance
Does this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?
mvn test -Dtest=TestIcebergCliDriver -Dqfile=iceberg_stats_with_ppr.q -Drat.skip=true
@deniskuzZ
Could you please add the jira Id.
I haven't found the file iceberg_partition_stats_with_ppr.q in the patch
Add support for Iceberg partition prune stats optimization
@deniskuzZ Could you please add the jira Id. I haven't found the file
iceberg_partition_stats_with_ppr.qin the patch
updated
Quality Gate passed
Issues
24 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarCloud
![sonarqubecloud[bot] avatar](https://avatars.githubusercontent.com/in/12526?v=4 "Published by a pub.dev verified publisher"){kind=small}
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Feel free to reach out on the [email protected] list if the patch is in need of reviews.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
in general, I cannot see any test coverage of this new feature, how does the added iceberg_stats_with_ppr.q.out show that it kicks in?
in general, I cannot see any test coverage of this new feature, how does the added iceberg_stats_with_ppr.q.out show that it kicks in?
- table has 5 rows, predicate returns 3 (before would be 5), see stats: https://github.com/apache/hive/pull/5498/files#diff-d6f6d58b1308192b6b3c9fcd75e2f5047e3817ad24900e2ecaca684569956d6eR56-R57
- count(*) explain shows no tasks, simple fetch from stats (before Map task was launched) https://github.com/apache/hive/pull/5498/files#diff-d6f6d58b1308192b6b3c9fcd75e2f5047e3817ad24900e2ecaca684569956d6eR78-R97
There are several Sonar issues in the modified classes. Other than that LGTM +1.
Quality Gate passed
Issues
111 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
See analysis details on SonarQube Cloud