Corey Carvalho

Results 11 comments of Corey Carvalho

Two tests break with Jekyll 4.2. Going to work on that and commit over the coming days. Edit: Discovered the change that broke the test: https://github.com/jekyll/jekyll/pull/8497/files

Hey @Martfed - I opened up https://github.com/jekyll/jekyll-admin/pull/631 to fix the failing tests. My plan was to rebase this PR onto the 631 once it gets approved and merged.

@Martfed I amended my commit message to force the test suite to run again... it looks like `jekyll-4.2.1` fixed the issue with the tests. If this passes, I'd love to...

I'm also experiencing this. Jekyll Admin: 0.11.0 Jekyll: 4.1.0 Edit: It seems to be when I edit my config from admin page.

I managed to trace the error back to https://github.com/jekyll/jekyll-admin/blob/1e8766166c74f013979536575b1e9ceddbb86be6/lib/jekyll-admin/file_helper.rb#L27 It looks like site.read might be causing the entire site (assets, html pages, etc) to be duplicated. This seems like a...

https://github.com/jekyll/jekyll-admin/pull/629 addresses this issue.

Yep, there should definitely be a new release of this gem.

Anyone around to review this? 😬

@ashmaroli hey - it looks like this issue is indeed fixed with `jekyll-4.2.1`

Any opposition to adding a Github workflow that publishes the gem on new tags? I'd like to get involved in automating this so that I can use it as a...