jekyll-admin icon indicating copy to clipboard operation
jekyll-admin copied to clipboard
verified publisher icon jekyll

Processes site when writing file

Open coreycarvalho opened this issue 4 years ago • 4 comments

This PR seeks to address https://github.com/jekyll/jekyll-admin/issues/623.

Instead of reading the entire site, which could lead to duplicating files, I opted to just re-process the site.

coreycarvalho avatar May 01 '21 21:05 coreycarvalho

Two tests break with Jekyll 4.2. Going to work on that and commit over the coming days.

Edit: Discovered the change that broke the test: https://github.com/jekyll/jekyll/pull/8497/files

coreycarvalho avatar May 02 '21 00:05 coreycarvalho

hi @coreycarvalho any news on this? If you need help I would be happy to do so

Martfed avatar May 20 '21 13:05 Martfed

Hey @Martfed - I opened up https://github.com/jekyll/jekyll-admin/pull/631 to fix the failing tests. My plan was to rebase this PR onto the 631 once it gets approved and merged.

coreycarvalho avatar May 20 '21 13:05 coreycarvalho

Awesome, thank you!

Martfed avatar May 20 '21 14:05 Martfed

@Martfed I amended my commit message to force the test suite to run again... it looks like jekyll-4.2.1 fixed the issue with the tests. If this passes, I'd love to get this merged in.

coreycarvalho avatar Aug 12 '22 16:08 coreycarvalho

Thanks @coreycarvalho

ashmaroli avatar Sep 08 '22 11:09 ashmaroli