jekyll-admin icon indicating copy to clipboard operation
jekyll-admin copied to clipboard

Fixes broken tests from 4.2

Open coreycarvalho opened this issue 4 years ago • 2 comments

This PR addresses https://github.com/jekyll/jekyll-admin/issues/630

The issue linked describes the issue.

For the apiable test, I opted to change the expected value to what liquid returns. This accounts for potential changes that Jekyll makes to the exact content returned.

For the page test, I opted to match against "Test Page", since we can reasonably expect that to be returned regardless of if Jekyll changes the exact values returned.

coreycarvalho avatar May 02 '21 18:05 coreycarvalho

Anyone around to review this? 😬

coreycarvalho avatar Dec 21 '21 19:12 coreycarvalho

@coreycarvalho Thank you for your contribution. Unfortunately, I think this change is no longer necessary.

Could you try reproducing #630 with jekyll-4.2.1 at your end?

ashmaroli avatar Dec 23 '21 14:12 ashmaroli

@ashmaroli hey - it looks like this issue is indeed fixed with jekyll-4.2.1

coreycarvalho avatar Aug 12 '22 16:08 coreycarvalho