Adrian Cole

> > I would be happy if I can contribute. Do you mean to add a new > HttpServerParser and HttpClientParser xray specific? > yeah, it will probably end up...

This can be easily chicken-egg problem since both module in future can be > dependent to each other. I am suggesting to either to add this new module > in...

thx for the trail blazing!

@cemo champion!

makes sense. I guess census is allowing you to create an exporter without a service name. This is a bug over there, but still, we should guard here also.

didn't notice this issue existed #77 partially implements it. v1 is not reverse mapped yet

Thanks for owning this! These are seeded from zipkin-api thrift? You can also compare against the following: https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/Tags.java https://github.com/openzipkin/brave/blob/master/instrumentation/rpc/src/main/java/brave/rpc/RpcTags.java https://github.com/openzipkin/brave/blob/master/instrumentation/http/src/main/java/brave/http/HttpTags.java https://github.com/openzipkin/brave/blob/94fe807e03160d779a0e98590b5f96fd824aa81a/brave/RATIONALE.md#why-we-dont-tag-errorfalse https://github.com/openzipkin/brave/tree/master/instrumentation/http#span-data-policy https://github.com/openzipkin/brave/tree/master/instrumentation/rpc#span-data-policy possibly import rationale from here: https://github.com/openzipkin/brave/blob/master/instrumentation/rpc/RATIONALE.md#why-use-rpcmethod-and-rpcservice https://github.com/openzipkin/brave/blob/master/instrumentation/rpc/RATIONALE.md#the-rpcerror_code-tag...

> > @adriancole In our data model, we > typically use the URL or operation name as the span name. Is there any > documentation about what values to typically...

I'd still hesitate on stackdriver being default.. Imagine when we have support for Google Pub/Sub collector. When that occurs it becomes more obvious why choosing a default could be problematic....

> > Makes sense. Perhaps the point of the gcr.io/stackdriver-trace- > docker/zipkin-collector image to set stackdriver as the storage? I'm not > sure where the associated Dockerfile for that is....