Adrian Cole

Results 2050 comments of Adrian Cole

the span name is currently hard-set. It could be possible to add a naming function instead, which could compose the value. A lot of instrumentation do things like this. https://github.com/openzipkin/zipkin-ruby/blob/master/lib/zipkin-tracer/rack/zipkin-tracer.rb#L24

PATH_INFO is likely to be variable, right? If so, it would explode the cardinality of span names which would cause usability (and also UI performance problems). The span name is...

seems there's a long discussion of how to get what's currently referred to as "http.route" from the rails env https://stackoverflow.com/questions/42691729/how-to-find-current-abstract-route-in-rails-middware see https://github.com/openzipkin/zipkin-api/pull/42 for http.route

here's the route-based span name logic we use in java if that helps? https://github.com/openzipkin/brave/blob/master/instrumentation/http/src/main/java/brave/http/HttpParser.java#L94

it won't be an error to set both

@zeagord Nov 23 21:59 > We are actually moving some of our services to GCP. And our span storage is in the on-premise. So it would be nice for us...

well it was a burst of traffic in wrk. I didn't look carefully or even Google. seems interesting they have a dashboard for this! unless it is a magic dashboard...

oh i don't run wrk 5 minutes.. most is 100 seconds. that was probably me running a couple times On Sat, Aug 17, 2019 at 8:15 PM Anuraag Agrawal wrote:...

I added output of the /info endpoint into the test script so we can verify if indeed there are hash problems. probably a good idea anyway ``` +curl --silent localhost:9411/info...

I opened a similar issue in spring-cloud-sleuth which is the other source of custom builds https://github.com/spring-cloud/spring-cloud-sleuth/issues/555