Adrian Cole

Results 2050 comments of Adrian Cole

oh. well this is done by virtue of the project re-org, as the default server build supports v2 format. v2 format is that swagger api you mentioned, and what all...

@artemyarulin the image you mention is the right one from https://github.com/openzipkin/docker-zipkin-gcp Is there a doc still mentioning gcr.io/stackdriver-trace-docker/zipkin-collector?

> > Yeah, reading > https://cloud.google.com/trace/docs/zipkin#container-image-option it says docker > pull gcr.io/stackdriver-trace-docker/zipkin-collector should be used > @mtwo I think we meant to change this a while back.. probably forgot to...

the non docker instructions change a bit as it is a layer on the normal server https://github.com/openzipkin/zipkin-gcp/tree/master/autoconfigure/storage-stackdriver#quick-start On Thu, Nov 15, 2018 at 3:50 AM Morgan McLean wrote: > >...

just started for me.. of course I made a mistake and literally used the project your_project! will add an issue, but yeah it works. I tried a trace from netflix...

agreed. also it is both an issue of bloat and more importantly pinning to unstable libraries. That said, because this is a leaf module for us, it is more about...

sadly this is still an issue

Lemme just check semantics of namespace quickly On 19 Oct 2017 22:23, "Cemalettin Koc" wrote: > @adriancole seems this part should be > splitted into if/else. > > https://github.com/openzipkin/zipkin-aws/blob/master/ >...

Looks like the name should be set in the condition where we check span.kind If span.kind != null set subsegment set namespace=remote set name = remoteServiceName Else set name =...

No worries.. seems like we might need a default http parser for x-ray, to pick the right fields. Ex http.url is not default https://github.com/openzipkin/brave/blob/master/instrumentation/http/README.md#span-data-policy Wanna try to make one for...