Adrian Cole

Results 2050 comments of Adrian Cole

related to integrations.. our other clouds have a "sender" which might be appropriate here. This would allow apps who already use zipkin-reporter-java implicitly (like spring-cloud-sleuth, brave, wingtips, jaeger) to plug...

ps mostly unrelated, but in some other implementations, when we start a span, we log a tick (or otherwise start a timer). When this is set (ex it wouldn't be...

> > The third is weird, "tha lack of this optional sampled header in fact > means you own this", weird. Current code will not like this > well, if...

in other words the sampled header is indeed required for any span that the caller reports to zipkin. I can fix the b3 docs as it seems unclear.

actually it is already there.. https://github.com/openzipkin/b3-propagation#details

Those instructions are out of date. Can you try openzipkin/zipkin-gcp image from docker-zipkin-gcp repo or what is mentioned here?

if you get a 202, then there was no problem parsing the json. You can turn on debug to see if there are any upload errors to stackdriver. You can...

Thanks for the notes. Yes `STORAGE_TYPE=stackdriver` is required as literally this is an extension of the normal server. For example, you can still use cassandra storage if you want *plus*...

https://github.com/openzipkin/zipkin-gcp/issues/74 to follow-up on README

Yep. We wandered a bit from that, but it is ok ;) On Tue, 10 Apr 2018, 08:27 Jeff White, wrote: > Can you clarify the original intent of this...