Robert J. Lang
Robert J. Lang
Tested, works great: * Changes the page title to "Reorder layouts at path _admin/dashboard_" (for example) * Adds a proper breadcrumb (shows the full breadcrumb trail) * Indicates which path...
Code looks good. (nice cleanups of existing code and comments.)
Just waiting on a response to the "preferred" vs "chosen" question (2 comments up) before marking this RTBC.
> To my understanding vertical tabs should never contain required fields. Correct me if I'm wrong, though. AFAIK the purpose of vertical tabs is to hide away things that can...
Tested the PR. Before:  After:  WFM (and a nice improvement!). Code reviewed, LGTM.
I would love to have this ability (restored). Tests are failing, though.
Code reviewed: LGTM. Tested: * Set value to 10, worked. * Set value to 10.5, got an error (appropriately). * Set value to 1000, got an error (appropriately) for max...
It looks like a simple change to get this across the finish line. @jromine, would you be open to a replacement PR (or a PR against your PR)?
Would like to get @hosef's input on this, but my understanding is that moving existing update hooks between modules is problematic because existing systems will have recorded those hooks as...