Robert J. Lang

Results 263 comments of Robert J. Lang

> I'd prefer if we find a solution without removing that cache. Not sure what would be smart here. Maybe we start by trying it without explicitly clearing the cache....

Well, that was suprising. If I just throw an exception in `simpletest_get_all()`, the attempted test run fails, but shows up green in the PR. Not what we want. ![test](https://user-images.githubusercontent.com/29214084/152616492-b17d8b7a-d6b0-4e0a-81d5-335d3a71b7ad.jpg)

So, how to turn that unhandled exception into a GHA failure exit code?

Much better. (I also eliminated the HTML formatting (`@uri` versus `%uri`) from the error messages to make them usable both in the UI and as GHA error messages.) ![test results](https://user-images.githubusercontent.com/29214084/152647795-ef7a43ed-0034-4938-881e-fc97e74aeba1.jpg)

I've now removed the intentional error (in `user.tests.info`) from the PR.

@indigoxela, @klonos, either of you up for a code review to get this to RTBC?

So, although Simpletest module is all about testing, the error messages in this PR are not "messages that result from running a test," but rather are messages that the user...

@indigoxela, @klonos, @argiepiano, any of you up for a code review of this?

@indigoxela, thanks for the review! I added some explanation to your first comment; more details are in [my comment above](https://github.com/backdrop/backdrop-issues/issues/5491#issuecomment-1172944489). I closed and reopened the PR, and now [PHPCS is...

@klonos points out that [this needs to support RTL](https://github.com/backdrop/backdrop/pull/3765#discussion_r723098864). PR is updated. New test HTML containing RTL cases is attached. [contextual_links_demo.html.txt](https://github.com/backdrop/backdrop-issues/files/7296286/contextual_links_demo.html.txt) A quick-and-dirty way to test RTL without having to...