Robert J. Lang
Robert J. Lang
Rebased the PR. I also added some comments and code changes to make clearer the delayed substitution of variables (still using '@' rather than '%' for clarity on the command...
@indigoxela, I think the PHPCS issues are being dealt with in your new issue (thanks!); would you (&/or @argiepiano) take a look at the new PR on this issue and...
> (separate issue perhaps though?) Yes, I'd suggest that. Both of those scenarios are ugly, but at least they're still usable. Whereas in the original scenario, the child menu isn't...
@indigoxela, thanks for taking a look! I've rebased the PR, so there's a new Tugboat demo. I've also created a test page, "Contextual links test", in the Tugboat demo, which...
@indigoxela, @stpaultim, @jenlampton, @klonos, any chance I could get a code review on this?
Typo fixed. > If down always works Yeah, but down doesn't always work if the nested items have a small height.
Here's another test case that needs to be covered (the current PR doesn't), which is likely to arise with Views, where the element that collides varies with the screen size...
I have provide a new PR in which the JS code for adjusting trigger positions is completely new. Among the changes: * It handles window resizing * It handles arbitrarily...
PR is updated with `backdrop.debounce()`.
I completely agree about the non-intuitive-ness of module_load_include(), and @jenlampton's suggested backdrop_load_include() makes good sense. Could we introduce backdrop_load_include() in a 1.x release, so that devs could start using it...