Robert J. Lang
Robert J. Lang
I created a new PR, https://github.com/backdrop/backdrop/pull/4520, based on https://github.com/backdrop/backdrop/pull/3512 so that I could play with it and see if I could figure out why tests were failing. Spelling was failing...
After some tinkering and testing... * There was a bug in the previous PR. The function `module_load_include()` still needs its return value (which is the return value from `backdrop_include_file()`). This...
I also noticed a related function, `module_load_all_includes()`, which cycles through all modules and calls `module_load_include()` for each. This is going to call `watchdog_deprecated_function()` for every module, which seems sort of...
I've removed the usage of `module_load_all_includes()` and added the same deprecation notice in it (referencing the same change record). I've confirmed in local testing that both of the `watchdog_deprecated_function()` notices...
> People's dblogs will fill up with deprecated notice. @argiepiano, only if they've turned on deprecated notices, which are not turned on by default. But your other point is well...
> What's the difference/benefit of 'details' over 'fieldset'? The `details` element is supported natively in browsers, IIRC. We used it for a similar use case of "additional information", for the...
I co-whinge on both points. Particularly on the second point. I'd never had reason to try to reorder layouts before, and when testing this PR, it took me a while...
Let's get it in, then. Tested: created several layouts for path _home_. Checked: * Page title is "Reorder layouts at path _home_" * Breadcrumb is Home > Administration > Structure...
I've reviewed the code; looks fine. I've created a follow-on issue to move reordering into the main Layouts page: https://github.com/backdrop/backdrop-issues/issues/5411. That would address the issue I raised above (also the...
Some suggestions on the above: * `/admin/structure/layouts/reorder` (no layout path provided) or `/admin/structure/layouts/reorder?gibberish`: * This seems like it warrants an error message, not a warning message * How about "No...