Aurora Rossi comments

Results 30 comments of


                                            Aurora Rossi

Coherent return types for Kruskal and Prim

@matbesancon

Coherent return types for Kruskal and Prim

Ok thanks @simonschoelly !

fix is_cyclic

Yes, this was an improvement only for connected graphs. I'm going to extend it to unconnected ones. Thank you!

fix is_cyclic

yes

Added strong_product, disjunctive_product, lexicographical_product, h…

Hi! We recently added a JuliaFormatter and this pull request was made earlier, so it was not aligned. I fixed this problem and now the controls are fine except for...

Algorithm for finding the longest path of a DAG

I had the same problem (I solved it in a PR that is still in progress). It should work by removing the parentheses in the runtest.jl file here: `ignore =...

Algorithm for finding the longest path of a DAG

> @aurorarossi Thanks, just made this, let's see now. @simonschoelly, I pushed the changes, what do you mean by making another PR? I am sorry, but this is my first...

Algorithm for finding the longest path of a DAG

It means that some lines are not covered by a test.

Improve visibility of contribution guidelines

Ah ok, I did not see it. I saw the code of conduct, which is visible near the README, but the contributing file is not as visible. It is ok...

Fix test laplacian lambda max

Yes and also in the function `_eigmax` there is the following line: ```jl KrylovKit.eigsolve(Symmetric(A), x0, 1, :LR)[1][1] ``` hence A is forced to be symmetric. When I run the tests...