fix is_cyclic

Open aurorarossi opened this issue 3 years ago • 2 comments

issue #34, now is_cyclic works for undirected connected graphs.

Jul 18 '22 15:07 aurorarossi

Thanks for your contribution, I think we should indeed change how this function works for undirected graphs. We probably also need to adapt the tests (that are currently failing) and the documentation for the changed behavior.

Jul 24 '22 18:07 simonschoelly

Yes, this was an improvement only for connected graphs. I'm going to extend it to unconnected ones. Thank you!

Jul 26 '22 09:07 aurorarossi

Hmm, I'm not sure what happened here? Did you try rebasing the PR?

Aug 25 '22 18:08 etiennedeg

yes

Aug 26 '22 09:08 aurorarossi

new PR here

Aug 26 '22 11:08 etiennedeg