Graphs.jl icon indicating copy to clipboard operation
Graphs.jl copied to clipboard

Coherent return types for Kruskal and Prim

Open aurorarossi opened this issue 3 years ago • 4 comments

Now both algorithms return a Vector{Edges}. I chose Vector{Edges} instead of Vector{SimpleWeightedEdge} because in this way the code is faster. In the case that weights are needed it is easy to query them. Issue #130

aurorarossi avatar Sep 12 '22 17:09 aurorarossi

Codecov Report

Merging #172 (c5b378f) into master (a3fb98b) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #172   +/-   ##
=======================================
  Coverage   97.54%   97.54%           
=======================================
  Files         109      109           
  Lines        6314     6314           
=======================================
  Hits         6159     6159           
  Misses        155      155           

codecov[bot] avatar Sep 12 '22 17:09 codecov[bot]

@matbesancon

aurorarossi avatar Sep 14 '22 14:09 aurorarossi

Hey Aurora, thanks for your PR.

While it might be a very good idea, to return the same types from both algorithms, changing that now would break existing code, so we rather do this when we bump the mayor version to v2.0.

simonschoelly avatar Sep 14 '22 15:09 simonschoelly

Ok thanks @simonschoelly !

aurorarossi avatar Sep 14 '22 15:09 aurorarossi