Jimmy Lu

Results 156 comments of Jimmy Lu

I think we need a `k-core.h` which does not include any macro of single character to make it easier to be used in real world projects. The old `k.h` can...

`RowContainer` is only used for spilling. If no spilling is happening,`destroy` still won't be called.

@ebeworld Try rebasing to newest master and see if the errors go away

@ebeworld No worry it's just unrelated warnings. I will merge it once the build is done.

@oerling There is a minor merge conflict

Looks like #2347 is the newest version

So far I don't see these 2 limitations as showstopper. For 1 we just need to use the new `mul` defined in `DecimalUtil.h`. For 2 we need to be careful...

FYI I probably found the root cause of 1. It's the Meta internal system that does not link clang `compiler_rt` by default. Once I add this, no more annotation will...

Bad news, due to some conflicts with Rust code, we probably still need to keep the annotations. I am going to give it a final try to fix our clang...

Just an update on this, I get some internal point of contact who will be fixing the Rust build system so that we can link compiler builtins properly. I will...