Jimmy Lu
Jimmy Lu
@nmahadevuni Can you rebase to main with the tests?
All exceptions are caught in `Driver::runInternal`. The stack trace you posted is a crash, not an exception
It's not rethrow, it's creating a VeloxException which includes the stacktrace with the original exception message. This error along should not cause crash, maybe some code path on the error...
Having branching every time when we do comparison/hashing is expensive. The most efficient way should be we normalize NaNs to the same value beforehand.
@rschlussel We will need to either normalize NaNs or use custom comparator anyway, I think a better way is to also normalize -0.0 to 0.0 or handle them in custom...
> > Do you have a plan to extend DictionaryVector to wrap more than one vectors, so that in some cases it can avoid too small-sized batches? > > that's...
@pedroerp Even the interface of `DecodedVector` need to be changed. `index`, `indices`, `data`, `base` in `DecodedVector` will no longer make sense and we will need remove them and fix all...
I have not measured, but the LazyVector mostly benefit when you have a non-pushdown filter (i.e. remaining expression) that on some smaller key columns, with very high filtering rate (>99.9%),...
@luhenry Can you rebase to the newest?