Jimmy Lu

Results 156 comments of Jimmy Lu

@gaoyangxiaozhu Can you just add a comment on the `kRowindex` explaining we need this because values for this meta column need to be generated by connector instead of passed from...

@zhli1142015 There are some memory leak detected in `GroupedExecutionTest`, you can repro them running the tests under ASAN: ``` Test appears to have passed but the binary exited with a...

@zhli1142015 Some heap-use-after-free: ``` Note: Google Test filter = HashTableTests/HashTableTest.failureInCreateRowPartitions/0 [==========] Running 1 test from 1 test suite. [----------] Global test environment set-up. [----------] 1 test from HashTableTests/HashTableTest [ RUN...

@mbasmanova This is similar to what you did for exchange in #7404 (a little different that we were accumulating pages instead of vectors there), shall we have some logic in...

@mbasmanova So we need to do it for all the filtering operators. Shall we add it in the driver run logic or add it to the separate operators?

I can start adding something to TableScan to implement this then So the idea is to accumulate the output of operator instead of input (except the Exchange we have already...

Thins we need are: 1. A utility to merge multiple vectors into one vector. Potentially reuse components from input (e.g. string buffers). Interface is simple (`RowVectorPtr merge(folly::Range)` but implementation can...

> If the number of input page rows is greater than MAX_BATCH_SIZE, output directly, This does not sound correct to me. The output of filtering operators is not directly related...

@majetideepak Try to reproduce it within a loop. Usually the alignment problem only shows up when vectorized