Marcos Spessatto Defendi
Marcos Spessatto Defendi
> I don't have the knowledge to say it will in fact break both systems, but the isRemote flag is also a generic flag to identify "not local users".. introducing...
> may I ask to change the PR title? It currently doesn't have a meaningful explanation to be shown on the change log. Is it really a `[NEW]`? it doesn't...
@bkraul actually this is the expected behavior, when you pin a message, an announcement is inserted in the channel (like you show on your GIF). When you unpin the message,...
> A UI test would also be great :) E2E UI tests will be done in a subsequent PR. Task: https://rocketchat.atlassian.net/browse/CORE-216
> if you're going to improve the UX it will change something to the end user, so it shouldn't be a `chore` Maybe a fix would fit better in this...
> Also, I think we should consider this a **breaking change** since this changes the output of the `rooms.autocomplete.channelAndPrivate` endpoint. I'll approve it for now since it looks fine to...
> Tested the change of button text setting in existing tests. But what about the issue? Isn't it about the color? đŸ¤” Didn't see anything mentioning the label..