Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

fix!: hide archived rooms in room.autocomplete endpoint

Open heitortanoue opened this issue 2 years ago β€’ 4 comments

Proposed changes (including videos or screenshots)

Issue with the create option discussion, the list when you choose the Channel or Group is showing Archived Teams/groups/channels

Issue(s)

Steps to test or reproduce

  • Create at least one channel/group/team and then archive them

  • Choose to create a discussion and then you will be able to pick this archived channel from the drop down suggestion list for parent channel

Further comments

SUP-286

heitortanoue avatar Jan 05 '24 14:01 heitortanoue

πŸ¦‹ Changeset detected

Latest commit: 1cd5c4991952e26cda14570bca06571f445676b8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jan 05 '24 14:01 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release-7.0.0@bb50bda). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #31383   +/-   ##
================================================
  Coverage                 ?   63.35%           
================================================
  Files                    ?     2037           
  Lines                    ?    47592           
  Branches                 ?    11096           
================================================
  Hits                     ?    30154           
  Misses                   ?    15594           
  Partials                 ?     1844           
Flag Coverage Ξ”
unit 74.79% <ΓΈ> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jan 05 '24 14:01 codecov[bot]

Also, I think we should consider this a breaking change since this changes the output of the rooms.autocomplete.channelAndPrivate endpoint. I'll approve it for now since it looks fine to me, but I'll mark it as a major change. Please tell me if you agree, @MarcosSpessatto

Yes, I agree. Let's keep this as a breaking change then. πŸ‘

MarcosSpessatto avatar Jan 10 '24 13:01 MarcosSpessatto

Looks like this PR is ready to merge! πŸŽ‰ If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Apr 09 '24 19:04 dionisio-bot[bot]

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-31383/ on branch gh-pages at 2024-10-16 11:16 UTC

github-actions[bot] avatar Oct 16 '24 11:10 github-actions[bot]