Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

feat: Improve UX from "Action Buttons" in `RoomInfo`

Open tiagoevanp opened this issue 1 year ago β€’ 6 comments

Proposed changes (including videos or screenshots)

Improve the UX from "Action Buttons" inside the contextualbar in RoomInfo component

Before: image

After: image

Issue(s)

Steps to test or reproduce

Further comments

CORE-464

tiagoevanp avatar Jun 19 '24 04:06 tiagoevanp

Looks like this PR is ready to merge! πŸŽ‰ If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Jun 19 '24 04:06 dionisio-bot[bot]

πŸ¦‹ Changeset detected

Latest commit: e08a7a2586e21d6b8ac471f6c162f2a68b1acf17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jun 19 '24 04:06 changeset-bot[bot]

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 55.63%. Comparing base (703af95) to head (e08a7a2).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32632      +/-   ##
===========================================
+ Coverage    55.56%   55.63%   +0.07%     
===========================================
  Files         2635     2637       +2     
  Lines        57292    57308      +16     
  Branches     11865    11868       +3     
===========================================
+ Hits         31834    31884      +50     
+ Misses       22768    22734      -34     
  Partials      2690     2690              
Flag Coverage Ξ”
e2e 54.38% <71.42%> (+0.09%) :arrow_up:
unit 72.34% <ΓΈ> (+0.09%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jun 19 '24 04:06 codecov[bot]

if you're going to improve the UX it will change something to the end user, so it shouldn't be a chore

dougfabris avatar Jun 19 '24 23:06 dougfabris

if you're going to improve the UX it will change something to the end user, so it shouldn't be a chore

Maybe a fix would fit better in this case, also adding a changeset.

MarcosSpessatto avatar Jun 20 '24 13:06 MarcosSpessatto

@tiagoevanp if you're improving, it's not a fix 😞

dougfabris avatar Jun 21 '24 15:06 dougfabris