Robert Hambrock

Bitcoin syncer silent failure using ssl://blockstream.info:993

1

Issue I described in IRC before already: when using ssl://blockstream.info:993 as the electrum server on testnet, without any other logged failures, start receiving only empty messages from blockstream.info. Thereafter, don't...

Add ability to re-attempt auto-funding swap if insufficient mature outputs

2

When operating multiple swaps, failure to autofund is quite frequent when operating (far) more swaps in parallel than UTXOs available and mostly ephemeral due to 1. Monero RPC: not enough...

get away from `Request::SweepMoneroAddress` / `Request::SweepBitcoinAddress` segregation see discussion https://github.com/farcaster-project/farcaster-node/pull/693#discussion_r961373964

health checks prior to making/taking

2

when user wants to initiate a swap, we should first check whether - [ ] monero-wallet-rpc is responsive - [ ] electrum server is responsive - [ ] monero daemon...

checkpoint after Alice funds, or ensure Alice has not funded before funding procedure

2

Maker Alice was restarted during a swap after funding, but prior to accordant lock finalizing, so before Bob sent her his buysig. After Alice restarts, Bob sees finalized accordant lock...

`AwaitingFunding..(..)` doesn't consistently decrement

6

See swap `0x28ef6b85b36d47d44820d999322e671bdf51c75b31f03c6f2be0d9db1303ffb9`: ``` [2021-12-16T04:14:52Z INFO farcaster_node::walletd::runtime] 0x28ef…ffb9 | Success(Swapped) in swap 0x28ef…ffb9, cleaning up data [2021-12-16T04:14:52Z INFO farcaster_node::swapd::runtime] 0x28ef…ffb9 | Terminating swap [2021-12-16T04:14:52Z INFO farcaster_node::peerd::runtime] Terminating peerd [2021-12-16T04:14:53Z WARN...

#364 scans for some blocks in the past when instructing the syncer to watch an address. This mitigates #361, but will not work always. It would be more reliable to...

Bob's maker doesn't pick up AccLock sometimes

1

Bob's maker log for swap `0x892e932cca6b639484fc3e9cc20609ff5344773da0398994c021024a47a2ddb0`: ``` Dec 14 10:17:20 farcaster02 farcasterd[1223340]: [2021-12-14T10:17:20Z INFO farcaster_node::swapd::runtime] Starting swap: 0x892e932cca6b639484fc3e9cc20609ff5344773da0398994c021024a47a2ddb0 Dec 14 10:17:20 farcaster02 farcasterd[1223340]: [2021-12-14T10:17:20Z INFO farcaster_node::swapd::runtime] 0x892e…ddb0 | Initial state:...

taker peerd panics if maker peerd times out during connection setup

1

Panic on TimedOut returned by PeerConnection::connect_brontozaur(..) since not handled here https://github.com/farcaster-project/farcaster-node/blob/d53c878d1bc3cae5e8425c7f1cf4d9a63a48041e/src/bin/peerd.rs#L228-L229 ``` [2022-10-03T09:37:36Z DEBUG peerd] MSG RPC socket /root/parallel-offer-taker/data_dirs/.data_dir_42/msg [2022-10-03T09:37:36Z DEBUG peerd] CTL RPC socket /root/parallel-offer-taker/data_dirs/.data_dir_42/ctl [2022-10-03T09:37:36Z INFO peerd] Local...