farcaster-project
checkpoint after Alice funds, or ensure Alice has not funded before funding procedure
Maker Alice was restarted during a swap after funding, but prior to accordant lock finalizing, so before Bob sent her his buysig.
After Alice restarts, Bob sees finalized accordant lock and sends her his buysig, but Alice has not restored the swap yet.
Alice restores the swap and since she hasn't checkpointed that she's funded, she auto-funds agains.
So we should either checkpoint after Alice funds, or Alice must first watch the accordant lock address and ensure it has not been funded before creating the funding request (currently, only checks whether address is watched thereafter, and doesn't check whether it already has txs).
Attached is Alice's log, @h4sh3d can provide Bob taker log if needed (Alice's log should be self-sufficient imo).
Thank you for the report, I think correct solution is that after a restore, needs funding should only be issued once the address has been checked by the syncers. Adding another checkpoint does not really solve the issue - Alice might terminate after she funded, but before the funding was registered in swapd.
