Siyu Wang

Results 214 comments of Siyu Wang

Hey guys @alvaroaleman @joelanford @vincepri @camilamacedo86 , what do you think? Please let me know if there’s anything else I should do. Your suggestions are very appreciated :)

> It really needs to be with them. I am more on the Kuebuilder side of the world. > In Kubebuilder we do have not the maintainers field (we only...

Yeah, looks like it had better define with `*metav1.Duration`. But I'm not sure if there are some ppl have already used it, which means change its type might break compatibility.

@danaradg Note that not all resource types have the `generation` field. Actually, most of the built-in types of K8s will not be set `generation` by kube-apiserver, while custom types will...

I'm afraid there is no documentation for this. You may have to read the code. `generation` is set by [PrepareForCreate](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/registry/rest/create.go#L59) function when created and increased by [PrepareForUpdate](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/apiserver/pkg/registry/rest/update.go#L51) function when modified...

> I'm not yet sure how can I know a resource is custom We can find out whether a resource is built-in or custom by recognizing it with the original...

> The handler for OnStoppedLeading exists but It is not entirely extendable to get a custom set of operations performed. @harshanarayana Yeah, now the `cm.onStoppedLeading` is only used for test,...