kubernetes-sigs
🌱 OWNERS_ALIASES: move fillzpp to maintainers
Signed-off-by: FillZpp [email protected]
Moves me (@FillZpp ) to maintainers to improve coverage for maintainer-requiring tasks, e.g. making releases (following RELEASE.md, thanks to @camilamacedo86 ).
Hey guys @alvaroaleman @joelanford @vincepri @camilamacedo86 , what do you think?
Please let me know if there’s anything else I should do. Your suggestions are very appreciated :)
Hi @FillZpp,
Hey guys @alvaroaleman @joelanford @vincepri @camilamacedo86 , what do you think? Please let me know if there’s anything else I should do. Your suggestions are very appreciated :)
It really needs to be with them. I am more on the Kuebuilder side of the world. In Kubebuilder we do have not the maintainers field (we only have https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/CONTRIBUTING-ROLES.md + admin), not sure how it has been defined/categorized here.
It really needs to be with them. I am more on the Kuebuilder side of the world. In Kubebuilder we do have not the maintainers field (we only have https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/CONTRIBUTING-ROLES.md + admin), not sure how it has been defined/categorized here.
Thanks, I understand. Although it seems Kubebuilder has both admin and maintainer roles.But controller-runtime (and controller-tools) are mostly using maintainer role, the admin list seems to be obsolete.
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle stale - Mark this issue or PR as rotten with
/lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: FillZpp
Once this PR has been reviewed and has the lgtm label, please assign alvaroaleman for approval by writing /assign @alvaroaleman in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages issues and PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the issue is closed
You can:
- Mark this issue or PR as fresh with
/remove-lifecycle rotten - Close this issue or PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alvaroaleman, FillZpp, varshaprasad96
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [alvaroaleman]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hey folks, just looking through this issue, I'm generally in favor of promoting new members to have a larger footprint in the community. That said, going by the community guidelines https://github.com/kubernetes/community/blob/master/community-membership.md I don't think we're quite there yet by looking at the amount of contributions done so far, or reviews.
If this is mostly about releases, I'd suggest that we work on automating the release process as much as possible through github actions, and have it self contained, like we did in the Cluster API project.
Hey folks, just looking through this issue, I'm generally in favor of promoting new members to have a larger footprint in the community. That said, going by the community guidelines https://github.com/kubernetes/community/blob/master/community-membership.md I don't think we're quite there yet by looking at the amount of contributions done so far, or reviews.
Oh, thanks for your feedback. I can add some information:
- I have posted 10+ PR and been merged, also I'm still working on some features like stoppable controllers/watches. This is partly due to the fact that there just aren't many of big changes in the project nowadays, but I'm still willing to make it better continuously.
- I have been part of 50+ issues, discussing, answering questions.
- I have involved and assigned in 80+ PPs, in most of them I helped review and gave my suggestions.
@vincepri Not sure which requirements you mentioned I'm still not reached from the membership doc. Could you please make it clear so that I could make my efforts towards it?
Thanks!
@FillZpp Thank you for the summary! I've missed a lot of these when I looked around.
LGTM, can we move though from maintainer to approver list?
Superseded by https://github.com/kubernetes-sigs/controller-runtime/pull/2088
/close
@vincepri: Closed this PR.
In response to this:
Superseded by https://github.com/kubernetes-sigs/controller-runtime/pull/2088
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.