Siyu Wang
Siyu Wang
I'm not sure, should we keep this test to verify that annotated on both field and type, to avoid bugs like these #688 and https://github.com/kubernetes-sigs/controller-tools/pull/693#issuecomment-1169433662
@jan--f I don't understand what's the difference between `NestedStructWithSeveralFields` and `NestedStructWithSeveralFieldsDoubleMarked `?
/remove-lifecycle stale
/remove-lifecycle stale
/remove-lifecycle stale The latest progress is here: https://github.com/kubernetes-sigs/kubebuilder/issues/1932#issuecomment-1112564792
@STRRL Thanks. Does the existing `WithWarnings` function not satisfy the requirement? https://github.com/kubernetes-sigs/controller-runtime/blob/26c95adfec6390a55f76b2c3ca73ffb532b12dec/pkg/webhook/admission/response.go#L116-L121 We can use it with any response like `Allowed()`, `Denied()` or `ValidationResponse()`. For example ```golang // ... return...
Emm... I don't really understand. `Handler` implementation just has to define a func `Handle(context.Context, Request) Response` and its response could also use the `WithWarnings`.
Oh, you mean expose the `Warnings` in the `Validator`/`CustomValidator` interfaces? In this way, we should not only expose the `Warnings`, but the `Response` with its fields like `Warnings`, `ErrorCode`, `Reason`....