Siyu Wang

Results 214 comments of Siyu Wang

Thanks for fixing this. /lgtm /cc @vincepri @alvaroaleman PTAL

@vincepri As I said above, it is not only caused by renewDeadline greater than lease duration. Any error occurred between `defer engageStopProcedure` in `controllerManager.Start()` and `// Start the leader elector...

@jcanseco Could you please describe your use-case that needs to remove watches(informers) dynamically?

Are A and B the resource kinds or the object names? I suppose they are the resource kinds. So you firstly watch two kinds, but you only care about **ONE...

Understand. Another question is, is there only one particular object of Resource B? Or there are multiple objects of Resource B, but you only need to watch the particular one...

> We have a controller manager with multiple controllers. Each controller manages all the objects with particular GVK. Our controller manager manages both GVK A and GVK B. All the...

@jcanseco If so, you may just have to use the channel source with generic event channel to trigger Controller A from Controller B. There is no need to create a...

> Ok, let me try to make sure I understand. Are you suggesting for us to have all controllers watch one channel (triggerChan), and then use that channel to allow...