EtherWizard33
EtherWizard33
seems like a lot of the checks, mostly related to e2e, are not passing, is it related to this PR?
for the CLA signature check that needs to pass above, I believe I followed the github actions comment above https://github.com/MetaMask/metamask-mobile/pull/9256#issuecomment-2058799917
> Component library changes LGTM! Approving to unblock. Please still get an approval from @EtherWizard33 🙏 Also needed approval from mobile platform code owners first. EtherWizard33 being a newcomer probably...
> why are we removing the close option in toast? Hi Brian, this PR got merged with too much content which included stuff about the close option which is not...
marked as a closed task in github projects
nice feature code LGTM
This is now fixed in this PR https://github.com/MetaMask/metamask-mobile/pull/9720
marked as closed
note: the no e2e and no qa labels are temporary, will add them once the feature works again
Nice feature, the description says 'percentage increase or decrease'. The following may be obvious for power users already... it's just a thought. When we talked about this feature together I...