refactor: the network name and image utils into selectors

[EtherWizard33]

Description

We are replacing calls to the get network name and get network image from utils to use a selector instead.

This way all places referring to it will do so in the same way and all with the same memoization provided by reselect.

Related issues

Fixes:

Manual testing steps

1. Where the network name and image were used before, the network name and image should still display after, there are about 15 places for each.
2. Mostly used for the network logos and it's network name used as a fallback letter
3. Other use cases are plainly to display the network name as text

Screenshots/Recordings

Here is a quick 2 minute overview of this PR:

Refactoring Overview - Watch Video

Before

After

Pre-merge author checklist

• [x] I’ve followed MetaMask Coding Standards.
• [ ] I've completed the PR template to the best of my ability
• [ ] I’ve included tests if applicable
• [ ] I’ve documented my code using JSDoc format if applicable
• [ ] I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions[bot]]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[github-actions[bot]]

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: a33206c20913c2ec65433ea71c724694c2d4f324 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/98283431-a90d-42fb-a479-7a702a2e7cac

[!NOTE]

• You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[tommasini]

@EtherWizard33 can we add recordings to the PR please?

[sonarqubecloud[bot]]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[EtherWizard33]

marked as closed