metamask-mobile icon indicating copy to clipboard operation
metamask-mobile copied to clipboard
verified publisher icon MetaMask

feat(4173): Send flow with contextual chain selector

Open EtherWizard33 opened this issue 1 year ago • 2 comments

Description

Send flow to use contextual chain selector, WIP.

Related issues

Contributes to: #13674

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

EtherWizard33 avatar Mar 10 '25 13:03 EtherWizard33

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions[bot] avatar Mar 10 '25 13:03 github-actions[bot]

note: the no e2e and no qa labels are temporary, will add them once the feature works again

EtherWizard33 avatar Jun 17 '25 17:06 EtherWizard33

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9c4ba0019919b2a7c4aef5bcabb7c8afe76810d8 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b77cf13c-cef9-4edd-9e57-3843847624d7

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jun 20 '25 19:06 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6f24502758b1f1a1abadeac22719196a6b3fcead Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/372ced18-b36c-4670-956c-80970637134c

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jul 08 '25 19:07 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 9ac353f7f7389c9de273212babcb6ddfc70c6e59 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/50c8e40a-03e1-432a-a18b-7f4233fc6746

[!NOTE]

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Jul 10 '25 19:07 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 97c275d031eaeb69ac637af0324e5a5c62eb56dd Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/57f92162-125a-4aea-88ad-6fd2194d6ee9

[!NOTE]

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Aug 04 '25 18:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: de5ea085a902660d08bb7c87f74076d074d8ab47 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/9d732695-d2f1-44d2-86f1-ae0a37bfbe6e

[!NOTE]

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Aug 04 '25 20:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: bcd8a6d7b924bd045a48a359811929a1b2dd4732 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c62080d5-6368-4da5-b69a-ed2d9f8789e1

[!NOTE]

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Aug 04 '25 22:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: f90f11d1813802d2c7decba6bcb06ddb37c9746f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ccdb84d2-74f4-44a6-ba16-c16dea8d810a

[!NOTE]

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Aug 05 '25 01:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 0837b45b600facdf4c7563e9ffa030e5d6fa287c Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/da80f61e-e7af-42f0-b9e2-70613a7c3a24

[!NOTE]

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Aug 05 '25 02:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 58024ff3430671fcd446f7e48fd9ddfe40b75887 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/0fe4c5a6-5533-4e7e-9229-94a7d8bdb7e5

[!NOTE]

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Aug 05 '25 13:08 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: f0129a60146192cc9c44ce719805963f3b7f47ba Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c2c1038a-55ac-4816-991d-e809864063bd

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 05 '25 17:08 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 885978eee526cd64252f5fd75bff9079177f0771 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/94a9c8fe-5e9d-4d86-830f-676dfae87316

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 05 '25 22:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 63fdf7abc9bc1fbfd243affc46725006d14a992f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fcf8985a-204c-4214-91b3-7e1773396480

[!NOTE]

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Aug 07 '25 14:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: c1aa6ee0c4268926d9d5d030ce69eba7ca811104 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/85ec0245-20e1-4d00-a474-2b114586b388

[!NOTE]

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Aug 07 '25 17:08 github-actions[bot]

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: ae5342c0f8fdb17837774172e96c83005d03b976 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a3143dd3-795b-4252-942f-cf670d9ab4af

[!NOTE]

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 07 '25 19:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 6228533b3359496bb13590acffba48f3adf6f73f Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/629f45da-2f5e-480a-83cc-1066384c92b8

[!NOTE]

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Aug 07 '25 19:08 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 8a6c56413f8336300827806c3ef7519ff6bdc5a3 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5e8dd1a5-9719-4995-a5c1-3f7eca622131

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 07 '25 20:08 github-actions[bot]

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 4967799d4149adb882f9dbc5603791c557dcb0d6 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/857bebc0-0648-4db9-be9a-5b0887e397b0

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 08 '25 16:08 github-actions[bot]

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 5e82193fe41f6beec431b87f2650db60e4662a37 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a6501a80-4573-41c5-a920-b25898a0843d

[!NOTE]

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

[!TIP]

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions[bot] avatar Aug 11 '25 02:08 github-actions[bot]

Sonar cloud coverage is skipped as we've added a decent amount of tests and coverage. There will also be another PR that performs a large refactor and we can follow up with more tests after the refactor is in.

Prithpal-Sooriya avatar Aug 11 '25 10:08 Prithpal-Sooriya

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d21b07042640c4543e64bc4a1b11914fb6e1e765 Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ccf335ca-b255-4f0d-a32b-f37250da5469

[!NOTE]

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

github-actions[bot] avatar Aug 11 '25 17:08 github-actions[bot]

Quality Gate Failed Quality Gate failed

Failed conditions
71.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

sonarqubecloud[bot] avatar Aug 11 '25 17:08 sonarqubecloud[bot]

Hi @EtherWizard33,

on the day following feat or perf PR merge, PM and author to test changes on main (feature + exploratory around the edges) using the latest nightly build with casual user persona and also a power user persona where performance might be a challenge. Please record the testing in a video, check the relevant post-merge checklist box below, and post the video in a comment at the bottom of this PR.

Author validation checklist

  • [ ] Validated the changes in main branch using the nightly build
  • [ ] Video shared

PM validation checklist

  • [ ] Validated the changes in main branch using the nightly build
  • [ ] Video shared

github-actions[bot] avatar Aug 11 '25 19:08 github-actions[bot]