0xNuggan
0xNuggan
Thanks for the review and the explainer! It makes total sense, let's keep it that way.
But it's not upgradeable right? Am I missing something?
Added the gap
Small one, but since it's high-prio: @FHieser ?
What's the state here @marvinkruse ? Something like this would be really useful, but at this point it's a bit out of date...
Closing since this will be taken over by the issue [SC-592](https://linear.app/inverter/issue/SC-592/task-restructure-scripts-directory-and-in-repo-documentation)
Changed them to the main Inverter repo in temp_dev for now. We will probably rethink the metadata at some point
We can't *really* prevent people from sending ETH to our contracts. See [here](https://medium.com/@alexsherbuck/two-ways-to-force-ether-into-a-contract-1543c1311c56) . Any ETH sent should be rescueable with `executeTx()`
Also: Review the hasModuleRole / hasRole functionalities to make it more intuitive. Maybe hasModuleRole takes address + role, so it can be called by users too. In general, even thouhg...
**Note before launch:** The main components of this PR have been merged into dev already. This PR will stay open after mainnet launch to be updated with the last batch...