0xNuggan

[SC-403] Q-6 Events without indexed attributes

1

## What has been done Added the `indexed` keyword to events in the KPI rewarder

[SC-391] Q-2 Unnecessary callback function declaration in IOptimisticOracleIntegrator

1

## What has been done Removed unnecessary callback function declarationa in IOptimisticOracleIntegrator and updated natspec comments

[SC-295] H-1 add storage slot gaps to layout

1

## What has been done Added a storage gap to all upgradeable modules. ## Open question I also added gaps to non-upgradeable abstract contracts if they are going to be...

Some scripts for new modules were missing (PaymentRouter,KPIRewarder,RestrictedBondingCurve). This PR adds them, together with a script to deploy a Q/Acc workflow

[SC-296] Bug(H-2): set BURN_ADMIN_ROLE during initialization

1

## What has been done - Moved `_setRoleAdmin(BURN_ADMIN_ROLE, BURN_ADMIN_ROLE);`to the initialization function - Added check to the tests Closes [SC-296]

Update the MetaData Module links in the scripts

1

The Module MetaData stores a link to the (supposed) Github of the Module. Right now, all links are made up. The repo structure seems stable enough to change them to...

hash the roleId with orchestrator address in getOwnerRole and getManagerRole

2

For consistency. Also make the role definition constants private in the process. Right now it's quite the footgun at best, bugged at worst, since the modules ask for the unhashed...

# Reconceptualization of the PaymentClient / PaymentProcessor relationship After reviewing Issue #199 I think it's not really valid anymore, but I still feel the PaymentClient / PaymentProcessor could use some...

Security Review #350: StreamingPaymentProcessor findings

2

### This issue is linked to - PR #350 ### Explanation - IStreamingPaymentProcessor uses an address as client for the claimForSpecificWalletId() function, while IPaymentProcessor uses an IERC20PaymentClient. Look into the...

Expand IFundingManager.transferOrchestratorToken() to include token address

1

Right now the arguments are `(address to, uint amount)` . We should include `address token` to that, so the orchestrator can rescue funds and simplify the flow for future multi-token...