contracts icon indicating copy to clipboard operation
contracts copied to clipboard
verified publisher icon InverterNetwork

[SC-760] Create Workflow Deployment Scripts

Open marvinkruse opened this issue 1 year ago • 4 comments

Ready to be worked on now.

marvinkruse avatar Aug 02 '24 13:08 marvinkruse

SC-760 Task: Create Workflow Deployment Scripts

linear[bot] avatar Aug 02 '24 13:08 linear[bot]

@0xNuggan This is the last commit that Felix added to his Scripts PR, now based on dev with his script changes. You can either build upon it or scrap it and do it however you want. Just FYI.

marvinkruse avatar Aug 02 '24 13:08 marvinkruse

Note before launch: The main components of this PR have been merged into dev already. This PR will stay open after mainnet launch to be updated with the last batch of changes and filled out with the missing workflow scripts.

0xNuggan avatar Aug 14 '24 13:08 0xNuggan

I did two changes:

  1. there was a bug in how the curve interaction role was assigned to the workflow admin after deployment which is fixed
  2. I removed the issuance token as return value from the createPIMWorkflows function to have consistency between the regular factory and this one for the sdk

fabianschu avatar Aug 19 '24 17:08 fabianschu

from my pov this can be closed

fabianschu avatar Aug 27 '24 13:08 fabianschu

Closing the PR as we internally decided to use the control room for deployments.

Zitzak avatar Sep 13 '24 11:09 Zitzak