zivanfi comments

Results 11 comments of


                                            zivanfi

PARQUET-1573: Add a docker development image and use it in travis

I'm not too familiar with docker, @gszadovszky maybe?

PARQUET-1573: Add a docker development image and use it in travis

Silently removing functionality that was added for a purpose is not good practice. Code reviews are not a substitute for automated checks, similar to how they do not make unit...

PARQUET-1408: Make parquet-tools display fields with missing values

I'll take another look, thanks. For future reviews In general I would suggest you to address review comments in a separate commit instead of amending and force-pushing. A separate commit...

PARQUET-1337: Current block alignment logic may lead to several row groups per block

@rdblue I started writing a DD about the solution that I plan to send to the dev list on Monday. Although Gabor approved this change, I don't plan to merge...

PARQUET-1337: Current block alignment logic may lead to several row groups per block

@rdblue, you can now review the [design doc](https://docs.google.com/document/d/1FJAVwzszZGkxZa8FtKtSbgBKm7qkS4cXuNW8hl4YKwU/edit#) for details. Thanks!

PARQUET-1292 Adding constructors to ProtoParquetWriter with writeSpecsCompliant flag

@chawlakunal, I added you the list of contributors so that you can assign JIRA-s to yourself. I assigned this one to you to make sure it works.

Feature request: xdiskusage-like layout made of vertical columns instead of horizontal bars

Hmm, funnily my reason for preferring the left-to-right layout is also label trimming. :) While the top levels clearly allow longer labels in the top-to-bottom layout, I often find that...

Issue #17 Add rendering mode using blocks of columns instead of bars

Screenshots: ![duviz-columns](https://user-images.githubusercontent.com/20930533/189478497-39f75c1b-6188-4c5d-b5f8-4a89676012eb.png) ![duviz-columns-colored](https://user-images.githubusercontent.com/20930533/189478503-b43bdc85-5850-4f3c-823d-f476e50b0766.png)

Issue #17 Add rendering mode using blocks of columns instead of bars

Closes soxofaan/duviz#17

Issue #17 Add rendering mode using blocks of columns instead of bars

Thanks for the review. A quick status update, since I couldn't find the time to finish the new revision, sorry about that: I modified the code to use characters covered...